feat(admin): Phase 4 — doctor, admin completeness, and bubbletea TUI
Adds the admin/diagnostics surface from SPEC §7.2: - doctor [--account]: per-account IMAP + (RW) SMTP connectivity/auth checks via new mail.CheckIMAP/CheckSMTP (connect+auth only, no mail). Exit non-zero on any failure; secrets never printed. - store.UpdateAccount: partial edit, re-encrypts password/secrets only when a non-empty value is supplied (blank keeps existing). RecentAuditFor(account). - config set/get (validates audit_retention_days), audit list [--account][--limit], account edit (flag partial-update) / remove [--yes]. - internal/tui: bubbletea AccountForm with pure, fully-tested Fields (validation + store.Account assembly + edit prefill). init / bare `account add` / `account edit --name X` drop into the TUI; flag forms remain for scripting. Built test-first; full suite green incl -race. Validated live against the mxlogin (password) and Gmail (app-password) accounts. Live validation caught a real bug: doctor authenticated with empty passwords because it iterated ListAccounts (which strips secrets) — fixed to re-fetch via GetAccount, locked in by a regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,93 @@
|
||||
package cli
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"io"
|
||||
|
||||
tea "github.com/charmbracelet/bubbletea"
|
||||
|
||||
"git.dcglab.co.uk/steve/emcli/internal/store"
|
||||
"git.dcglab.co.uk/steve/emcli/internal/tui"
|
||||
)
|
||||
|
||||
// runForm launches the bubbletea account form and returns the final model.
|
||||
// This is interactive terminal glue (not unit-tested); all logic it relies on
|
||||
// lives in the tui and store packages, which are tested.
|
||||
func runForm(initial tui.Fields, editing bool) (tui.AccountForm, error) {
|
||||
p := tea.NewProgram(tui.NewAccountForm(initial, editing))
|
||||
m, err := p.Run()
|
||||
if err != nil {
|
||||
return tui.AccountForm{}, err
|
||||
}
|
||||
return m.(tui.AccountForm), nil
|
||||
}
|
||||
|
||||
// addInteractive runs the form for a new account and persists it.
|
||||
func addInteractive(st *store.Store, initial tui.Fields, out, errOut io.Writer) int {
|
||||
form, err := runForm(initial, false)
|
||||
if err != nil {
|
||||
fmt.Fprintf(errOut, "form: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
if form.Cancelled() {
|
||||
fmt.Fprintln(out, "cancelled")
|
||||
return 1
|
||||
}
|
||||
acc := form.Account()
|
||||
if _, err := st.AddAccount(acc); err != nil {
|
||||
fmt.Fprintf(errOut, "add account: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
fmt.Fprintf(out, "account %q added (%s)\n", acc.Name, acc.Mode)
|
||||
return 0
|
||||
}
|
||||
|
||||
// editInteractive runs the form prefilled from an existing account and saves it.
|
||||
func editInteractive(st *store.Store, name string, out, errOut io.Writer) int {
|
||||
acc, err := st.GetAccount(name)
|
||||
if err != nil {
|
||||
fmt.Fprintf(errOut, "edit: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
form, err := runForm(tui.FieldsFromAccount(acc), true)
|
||||
if err != nil {
|
||||
fmt.Fprintf(errOut, "form: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
if form.Cancelled() {
|
||||
fmt.Fprintln(out, "cancelled")
|
||||
return 1
|
||||
}
|
||||
updated := form.Account()
|
||||
if !form.PasswordSet() {
|
||||
updated.Password = "" // blank ⇒ UpdateAccount keeps the existing password
|
||||
}
|
||||
if err := st.UpdateAccount(updated); err != nil {
|
||||
fmt.Fprintf(errOut, "edit: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
fmt.Fprintf(out, "account %q updated\n", name)
|
||||
return 0
|
||||
}
|
||||
|
||||
// runInit creates/opens the DB and adds the first account via the TUI form,
|
||||
// seeding a default audit retention if unset.
|
||||
func runInit(args []string, out, errOut io.Writer) int {
|
||||
st, err := openStore()
|
||||
if err != nil {
|
||||
fmt.Fprintf(errOut, "emcli: %v\n", err)
|
||||
return 1
|
||||
}
|
||||
defer st.Close()
|
||||
|
||||
if _, err := st.GetSetting("audit_retention_days"); err != nil {
|
||||
_ = st.SetSetting("audit_retention_days", "90")
|
||||
}
|
||||
accs, _ := st.ListAccounts()
|
||||
if len(accs) > 0 {
|
||||
fmt.Fprintf(out, "emcli is already initialized (%d account(s)); adding another.\n", len(accs))
|
||||
} else {
|
||||
fmt.Fprintln(out, "Initializing emcli — add your first account.")
|
||||
}
|
||||
return addInteractive(st, tui.Fields{}, out, errOut)
|
||||
}
|
||||
Reference in New Issue
Block a user