feat(cli): agent read commands (list/get/search/ack) with policy filtering

internal/cli/agent_test.go

@@ -0,0 +1,169 @@
+package cli
+
+import (
+	"bytes"
+	"encoding/json"
+	"path/filepath"
+	"testing"
+	"time"
+
+	"git.dcglab.co.uk/steve/emcli/internal/mail"
+	"git.dcglab.co.uk/steve/emcli/internal/store"
+)
+
+type fakeMailer struct {
+	uidValidity uint32
+	maxUID      uint32
+	headers     []mail.Header
+	full        map[uint32]mail.Message
+}
+
+func (f *fakeMailer) SelectFolder(string) (uint32, uint32, error) { return f.uidValidity, f.maxUID, nil }
+func (f *fakeMailer) FetchHeaders(_ string, uids []uint32) ([]mail.Header, error) {
+	if len(uids) == 0 {
+		return f.headers, nil
+	}
+	want := map[uint32]bool{}
+	for _, u := range uids {
+		want[u] = true
+	}
+	var out []mail.Header
+	for _, h := range f.headers {
+		if want[h.UID] {
+			out = append(out, h)
+		}
+	}
+	return out, nil
+}
+func (f *fakeMailer) FetchHeadersRange(string, uint32, uint32, int) ([]mail.Header, error) {
+	return f.headers, nil
+}
+func (f *fakeMailer) FetchFull(_ string, uid uint32) (mail.Message, error) {
+	return f.full[uid], nil
+}
+func (f *fakeMailer) Search(string, mail.SearchCriteria, int) ([]mail.Header, error) {
+	return f.headers, nil
+}
+func (f *fakeMailer) Logout() error { return nil }
+
+func testKey() []byte {
+	k := make([]byte, 32)
+	for i := range k {
+		k[i] = byte(i)
+	}
+	return k
+}
+
+func newDeps(t *testing.T, fm *fakeMailer) (Deps, *bytes.Buffer) {
+	t.Helper()
+	st, err := store.Open(filepath.Join(t.TempDir(), "e.db"), testKey())
+	if err != nil {
+		t.Fatalf("store: %v", err)
+	}
+	t.Cleanup(func() { st.Close() })
+	_, err = st.AddAccount(store.Account{
+		Name: "work", Mode: "RO", IMAPHost: "h", IMAPPort: 993, IMAPSecurity: "tls",
+		AuthType: "password", Username: "me@example.com", Password: "pw",
+		WhitelistInEnabled: true,
+	})
+	if err != nil {
+		t.Fatalf("AddAccount: %v", err)
+	}
+	_ = st.AddWhitelist("work", store.DirIn, "@trusted.com")
+	var buf bytes.Buffer
+	d := Deps{
+		Store: st,
+		Dial:  func(store.Account) (Mailer, error) { return fm, nil },
+		Now:   func() time.Time { return time.Date(2026, 6, 21, 0, 0, 0, 0, time.UTC) },
+		Out:   &buf,
+	}
+	return d, &buf
+}
+
+func decode(t *testing.T, b []byte) map[string]any {
+	t.Helper()
+	var m map[string]any
+	if err := json.Unmarshal(b, &m); err != nil {
+		t.Fatalf("unmarshal %q: %v", b, err)
+	}
+	return m
+}
+
+func TestListNewFiltersBySenderAndState(t *testing.T) {
+	fm := &fakeMailer{
+		uidValidity: 1, maxUID: 100,
+		headers: []mail.Header{
+			{UID: 101, From: "bob@trusted.com", Subject: "hi"},
+			{UID: 102, From: "eve@evil.com", Subject: "spam"}, // filtered out by whitelist
+			{UID: 103, From: "ann@trusted.com", Subject: "yo"},
+		},
+	}
+	d, buf := newDeps(t, fm)
+	if err := ListCmd(d, "work", "INBOX", true, 0, 0, 50); err != nil {
+		t.Fatalf("ListCmd: %v", err)
+	}
+	res := decode(t, buf.Bytes())
+	if res["error"] != false {
+		t.Fatalf("unexpected error: %v", res)
+	}
+	data := res["data"].(map[string]any)
+	msgs := data["messages"].([]any)
+	if len(msgs) != 2 { // 101 and 103; 102 filtered
+		t.Fatalf("want 2 messages, got %d: %v", len(msgs), msgs)
+	}
+}
+
+func TestGetFilteredReturnsNotFound(t *testing.T) {
+	fm := &fakeMailer{
+		uidValidity: 1, maxUID: 100,
+		headers: []mail.Header{{UID: 102, From: "eve@evil.com", Subject: "spam"}},
+		full: map[uint32]mail.Message{
+			102: {Header: mail.Header{UID: 102, From: "eve@evil.com", Subject: "spam"}, BodyText: "secret"},
+		},
+	}
+	d, buf := newDeps(t, fm)
+	if err := GetCmd(d, "work", "INBOX", 102); err != nil {
+		t.Fatalf("GetCmd: %v", err)
+	}
+	res := decode(t, buf.Bytes())
+	if res["error"] != true {
+		t.Fatal("filtered get must return error envelope")
+	}
+	ed := res["error_detail"].(map[string]any)
+	if ed["code"] != "not_found" {
+		t.Fatalf("want not_found, got %v", ed["code"])
+	}
+}
+
+func TestAckAdvancesStateAndFiltered(t *testing.T) {
+	fm := &fakeMailer{
+		uidValidity: 1, maxUID: 100,
+		headers: []mail.Header{
+			{UID: 101, From: "bob@trusted.com", Subject: "hi"},
+			{UID: 102, From: "eve@evil.com", Subject: "spam"},
+		},
+	}
+	d, buf := newDeps(t, fm)
+	// Acking a filtered uid (102) must be rejected as not-found.
+	if err := AckCmd(d, "work", "INBOX", []uint32{102}); err != nil {
+		t.Fatalf("AckCmd: %v", err)
+	}
+	if decode(t, buf.Bytes())["error"] != true {
+		t.Fatal("acking filtered uid must fail")
+	}
+	// Acking a visible uid (101) succeeds and removes it from list --new.
+	buf.Reset()
+	if err := AckCmd(d, "work", "INBOX", []uint32{101}); err != nil {
+		t.Fatalf("AckCmd 101: %v", err)
+	}
+	if decode(t, buf.Bytes())["error"] != false {
+		t.Fatal("ack of visible uid should succeed")
+	}
+	buf.Reset()
+	_ = ListCmd(d, "work", "INBOX", true, 0, 0, 50)
+	data := decode(t, buf.Bytes())["data"].(map[string]any)
+	msgs := data["messages"].([]any)
+	if len(msgs) != 0 { // 101 acked, 102 filtered
+		t.Fatalf("want 0 new messages, got %d", len(msgs))
+	}
+}