steve
ee3ee241ea
Cohesive batch from a smoke-test session against a real rest-server.
Themed bullets:
* Agent runs as root, sandboxed via systemd. CapabilityBoundingSet
drops to CAP_DAC_READ_SEARCH + restore caps; ProtectSystem=strict
with ReadWritePaths confined to /etc + /var/lib/restic-manager;
NoNewPrivileges blocks escalation. Install script no longer
creates a service user. spec.md §4.2 / §14.1 / §14.3 explain the
rationale (matches UrBackup / Veeam / Bareos defaults; trying to
back up "everything" as an unprivileged user creates silent skips
on /home, /root, /var/lib/* with no upside vs the threat model
the agent already implies).
* Init-repo end-to-end. New JobKind="init" wired through agent
runner, restic.Env.RunInit, server dispatcher, and a UI button
(red "Initialise repo" in the run-now panel). hosts.repo_initialised_at
flips on init success, on backup success, or on a non-empty
snapshots.report. The "Run now" / "Init" / "Retry" branching now
drives both the dashboard host row and the host-detail panel.
Migrations 0004 (column), 0005 (jobs.kind CHECK widened — using
the safe create-new-then-rename pattern; first version corrupted
job_logs.job_id FK), 0006 (cleans up job_logs FK on already-
affected DBs).
* rest-server creds embedded at exec time only. restic.Env gains
RepoUsername; mergeRestCreds() builds the user:pass@-prefixed URL
inside envSlice() and never assigns it back to the struct, so
nothing slog-able ever sees the cleartext form. RedactURL helper
for any future surface that needs to log a URL safely. Both
helpers tested.
* Add-host UX. Repo password is now optional — server mints a
24-byte URL-safe random one and surfaces it once, alongside an
htpasswd snippet ("echo PASS | htpasswd -B -i ... USERNAME") so
the operator pastes one command on the rest-server host and one
on the endpoint. Result page also links the install snippet at
/install/install.sh (was /install.sh — 404'd before) and pipes
to bash (not sh — script uses set -o pipefail and other
bashisms; on Debian/Ubuntu sh is dash).
* Late-subscriber race in JobHub. A fast-failing job could finish
(DB write + Broadcast) before the browser's HX-Redirect → page
load → WS-connect path completed, so the JS sat forever waiting
on a job.finished that already passed. JobHub split into
Register + Send + Run; handleJobStream now subscribes first,
re-fetches the job, and sends a synthetic job.finished if the
state is already terminal.
* HTMX error visibility. New toast partial listens to
htmx:responseError and surfaces the response body as a
bottom-right toast — every server-side validation error now
becomes visible without per-handler JS wiring. Also handles
custom rm:toast events for future server-pushed notifications
via the HX-Trigger header. Themed via existing CSS vars.
* Dashboard rows are now whole-row clickable to host detail
(CSS card-link pattern: absolute-positioned anchor + .row-action
z-index restoration so the action button stays clickable).
"View →" on a running job links to /jobs/<id> rather than
/hosts/<id> since the row click already covers the host page.
* "Run first" / "Run first backup" → "Run now" everywhere for
consistency.
* runbook (docs/e2e-smoke.md) updated — live-log streaming step
now reflects P1-26; mentions the browser-driven Run-now flow.
* _diag/dump-creds — moved out of cmd/ so go build doesn't pick
it up; .gitignore now excludes /_diag/ entirely.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
74 lines
3.3 KiB
HTML
74 lines
3.3 KiB
HTML
{{define "host_row"}}
|
|
<div class="row-hover host-row clickable hairline {{.Status}}{{if eq (deref .LastBackupStatus) "failed"}} failed{{end}}">
|
|
<a href="/hosts/{{.ID}}" class="row-link" aria-label="Open {{.Name}}">{{.Name}}</a>
|
|
<div>
|
|
{{- if eq .Status "online" -}}
|
|
<span class="dot dot-online{{if .CurrentJobID}} pulse{{end}}"></span>
|
|
{{- else if eq .Status "degraded" -}}
|
|
<span class="dot dot-degraded"></span>
|
|
{{- else if eq .Status "offline" -}}
|
|
<span class="dot dot-offline"></span>
|
|
{{- else -}}
|
|
<span class="dot dot-failed"></span>
|
|
{{- end -}}
|
|
</div>
|
|
<div class="mono {{if eq .Status "offline"}}text-ink-mid{{else}}text-ink{{end}} font-medium">{{.Name}}</div>
|
|
<div class="mono text-ink-mid text-[12px]">{{.OS}}/{{.Arch}}</div>
|
|
<div class="text-xs text-ink-mid">
|
|
{{- if .CurrentJobID -}}
|
|
<span class="text-accent">backup running…</span><br>
|
|
<span class="mono text-ink-fade">started {{relTime .LastBackupAt}}</span>
|
|
{{- else if eq (deref .LastBackupStatus) "succeeded" -}}
|
|
<span class="text-ok">succeeded</span> · <span class="mono">{{relTime .LastBackupAt}}</span>
|
|
{{- else if eq (deref .LastBackupStatus) "failed" -}}
|
|
<span class="text-bad font-medium">failed</span> · <span class="mono">{{relTime .LastBackupAt}}</span>
|
|
{{- else if eq (deref .LastBackupStatus) "cancelled" -}}
|
|
<span class="text-warn">cancelled</span> · <span class="mono">{{relTime .LastBackupAt}}</span>
|
|
{{- else if eq .Status "offline" -}}
|
|
<span class="text-ink-mute">last seen <span class="mono">{{relTime .LastSeenAt}}</span></span>
|
|
{{- else -}}
|
|
<span class="text-ink-fade italic">never run</span>
|
|
{{- end -}}
|
|
</div>
|
|
<div class="text-right mono {{if eq .Status "offline"}}text-ink-mid{{else}}text-ink{{end}}">{{bytes .RepoSizeBytes}}</div>
|
|
<div class="text-right mono {{if eq .Status "offline"}}text-ink-mute{{else}}text-ink-mid{{end}}">
|
|
{{- if eq .SnapshotCount 0 -}}
|
|
<span class="text-ink-fade">—</span>
|
|
{{- else -}}
|
|
{{comma .SnapshotCount}}
|
|
{{- end -}}
|
|
</div>
|
|
<div class="text-right mono {{if gt .OpenAlertCount 0}}text-bad font-medium{{else}}text-ink-mute{{end}}">
|
|
{{- if eq .OpenAlertCount 0 -}}—{{- else -}}{{.OpenAlertCount}}{{- end -}}
|
|
</div>
|
|
<div class="flex gap-1.5 flex-wrap">
|
|
{{- range .Tags -}}
|
|
<span class="tag">{{.}}</span>
|
|
{{- end -}}
|
|
</div>
|
|
<div class="text-right row-action">
|
|
{{- if eq .Status "offline" -}}
|
|
<span class="mono text-xs text-ink-fade">offline</span>
|
|
{{- else if .CurrentJobID -}}
|
|
<a href="/jobs/{{deref .CurrentJobID}}" class="btn btn-ghost">View job →</a>
|
|
{{- else if not .RepoInitialisedAt -}}
|
|
<button class="btn btn-danger"
|
|
hx-post="/hosts/{{.ID}}/init-repo"
|
|
hx-swap="none"
|
|
hx-disabled-elt="this"
|
|
title="restic repo not yet initialised">Init repo</button>
|
|
{{- else if eq (deref .LastBackupStatus) "failed" -}}
|
|
<button class="btn"
|
|
hx-post="/hosts/{{.ID}}/run-backup"
|
|
hx-swap="none"
|
|
hx-disabled-elt="this">Retry</button>
|
|
{{- else -}}
|
|
<button class="btn"
|
|
hx-post="/hosts/{{.ID}}/run-backup"
|
|
hx-swap="none"
|
|
hx-disabled-elt="this">Run now</button>
|
|
{{- end -}}
|
|
</div>
|
|
</div>
|
|
{{end}}
|