steve
8fb1c100fd
Two independent path lists for "what does this host back up?" was
a real divergence footgun — operator types one set at Add-host time
and a different set into a schedule, both end up in the same repo,
the snapshot history looks fine until restore. Resolution: drop
host.default_paths entirely; add a `manual` flag on schedules.
A manual schedule has paths/excludes/tags/retention like any other
but no cron — it fires only via per-schedule Run-now. Single source
of truth for what gets backed up.
Schema (migration 0007):
* schedules.manual INTEGER NOT NULL DEFAULT 0.
* For every host with non-empty default_paths, seed a manual
schedule with those paths and bump host_schedule_version.
* ALTER TABLE hosts DROP COLUMN default_paths.
* ALTER TABLE enrollment_tokens RENAME COLUMN default_paths
TO initial_paths.
Original draft of this migration rebuilt hosts via the
create-new + drop-old + rename-new pattern. With foreign_keys=ON
(set in the connection DSN), DROP TABLE on the parent fired
ON DELETE CASCADE on every child of hosts(id) — schedules /
jobs / snapshots / host_credentials all wiped on the smoke env
when I tried it. SQLite 3.35+ supports column-level ALTERs
directly, so we skip the rebuild dance and avoid the cascade
trap. Six lines of SQL instead of sixty, no FK risk.
Run-now rewiring:
* New `dispatchScheduleNow(hostID, scheduleID, conn?)` helper
unifies the agent-driven path (cron fire → schedule.fire →
OnScheduleFire callback) and the UI-driven path (operator
clicks Run-now on a schedule row). Conn arg is optional; nil
falls back to Hub.Send.
* New POST /hosts/{id}/schedules/{sid}/run endpoint — per-row
Run-now button on the schedules list.
* Dashboard's per-host Run-now (handleUIRunBackup) now picks the
host's only enabled manual schedule, falls back to the only
enabled schedule, else returns "pick one in Schedules tab".
Keeps one-click for the common case.
Agent:
* Scheduler skips manual schedules in cron build (silent — they're
a normal data shape, not an error).
* Wire Schedule struct gains Manual flag.
* Schedule.fire flow unchanged — the agent only ever fires
non-manual schedules anyway.
UI:
* Add-host form retitled "Initial schedule · manual" so the
operator knows the paths become an editable schedule under
the Schedules tab. Result page calls out the manual schedule
+ points at Host > Schedules.
* Schedule edit form: "Manual schedule" checkbox at the top of
the When section; toggling it hides/shows the cron field via
inline JS. Server-side validator skips the cron requirement
when manual=true.
* Schedule list shows a "manual" tag under the status pill and
renders the When column as "— run-now only —" for manual rows.
Each row gets a Run-now button when the schedule is enabled
and the host is online.
Tests + go test ./... green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
106 lines
4.8 KiB
HTML
106 lines
4.8 KiB
HTML
{{define "title"}}{{.Title}}{{end}}
|
|
|
|
{{define "content"}}
|
|
{{$page := .Page}}
|
|
{{$host := $page.Host}}
|
|
<div class="max-w-[1280px] mx-auto px-8 pt-7 pb-14">
|
|
|
|
<div class="crumbs">
|
|
<a href="/">Dashboard</a><span class="sep">/</span>
|
|
<a href="/hosts/{{$host.ID}}">{{$host.Name}}</a><span class="sep">/</span>
|
|
<span class="text-ink-mid">schedules</span>
|
|
</div>
|
|
|
|
{{/* ---------- header ---------- */}}
|
|
<div class="flex items-start justify-between mt-3.5">
|
|
<div>
|
|
<div class="flex items-center gap-3">
|
|
{{if eq $host.Status "online"}}
|
|
<span class="dot dot-online"></span>
|
|
{{else}}
|
|
<span class="dot dot-offline"></span>
|
|
{{end}}
|
|
<h1 class="text-[22px] font-medium tracking-[-0.01em]">
|
|
schedules <span class="text-ink-fade">·</span>
|
|
<span class="mono text-ink font-medium">{{$host.Name}}</span>
|
|
</h1>
|
|
<span class="mono text-[11px] text-ink-mute">version {{$page.Version}}{{if and (gt $page.Version 0) (ne $page.Version $page.AppliedVersion)}} <span class="text-warn">· agent at v{{$page.AppliedVersion}}</span>{{else if gt $page.Version 0}} <span class="text-ok">· agent in sync</span>{{end}}</span>
|
|
</div>
|
|
</div>
|
|
<div class="flex items-center gap-2">
|
|
<a href="/hosts/{{$host.ID}}/schedules/new" class="btn btn-primary">New schedule</a>
|
|
</div>
|
|
</div>
|
|
|
|
{{/* ---------- secondary tabs ---------- */}}
|
|
<div class="flex items-end mt-7">
|
|
<a class="sub-tab" href="/hosts/{{$host.ID}}">Snapshots <span class="mono text-ink-fade text-[11px] ml-1">{{comma $host.SnapshotCount}}</span></a>
|
|
<a class="sub-tab active" href="/hosts/{{$host.ID}}/schedules">Schedules <span class="mono text-ink-fade text-[11px] ml-1">{{len $page.Schedules}}</span></a>
|
|
<div class="sub-tab">Jobs</div>
|
|
<div class="sub-tab">Repo</div>
|
|
<div class="sub-tab">Settings</div>
|
|
</div>
|
|
|
|
{{/* ---------- schedule rows ---------- */}}
|
|
<div class="panel rounded-[7px] mt-6 overflow-hidden">
|
|
{{if eq (len $page.Schedules) 0}}
|
|
<div class="empty-state" style="border: none; background: var(--panel);">
|
|
<h3 class="text-base font-medium tracking-[-0.005em]">No schedules yet.</h3>
|
|
<p class="text-pretty text-ink-mute text-[13px] mt-2 mx-auto max-w-[480px] leading-[1.65]">
|
|
Add one and the agent will start running backups on whatever cron expression you give it.
|
|
Until then, run-now is the only way to trigger a backup.
|
|
</p>
|
|
<div class="mt-5">
|
|
<a href="/hosts/{{$host.ID}}/schedules/new" class="btn btn-primary">New schedule</a>
|
|
</div>
|
|
</div>
|
|
{{else}}
|
|
<div class="hairline grid items-baseline px-4 py-2.5 text-[11px] text-ink-fade uppercase tracking-[0.08em]"
|
|
style="grid-template-columns: 0.6fr 1.1fr 2fr 1.3fr 0.5fr 1fr; column-gap: 18px;">
|
|
<div>Status</div>
|
|
<div>When</div>
|
|
<div>Paths</div>
|
|
<div>Retention</div>
|
|
<div>Tags</div>
|
|
<div></div>
|
|
</div>
|
|
{{range $page.Schedules}}
|
|
<div class="grid items-center px-4 py-3 text-[13px] hairline"
|
|
style="grid-template-columns: 0.6fr 1.1fr 2fr 1.3fr 0.5fr 1fr; column-gap: 18px;">
|
|
<div class="flex flex-col gap-0.5">
|
|
{{if .Enabled}}
|
|
<span class="mono text-[11px] text-ok">enabled</span>
|
|
{{else}}
|
|
<span class="mono text-[11px] text-ink-fade">disabled</span>
|
|
{{end}}
|
|
{{if .Manual}}
|
|
<span class="mono text-[10.5px] text-ink-mute">manual</span>
|
|
{{end}}
|
|
</div>
|
|
<div class="mono text-ink">{{if .Manual}}<span class="text-ink-fade">— run-now only —</span>{{else}}{{.CronExpr}}{{end}}</div>
|
|
<div class="mono text-ink-mid text-[12px] truncate" title="{{joinDot .Paths}}">{{joinDot .Paths}}</div>
|
|
<div class="mono text-[12px] text-ink-mid">{{.RetentionPolicy.Summary}}</div>
|
|
<div class="flex gap-1.5 flex-wrap">
|
|
{{- range .Tags -}}<span class="tag">{{.}}</span>{{- end -}}
|
|
</div>
|
|
<div class="text-right flex gap-1.5 justify-end">
|
|
{{if and .Enabled (eq $host.Status "online")}}
|
|
<button class="btn btn-primary"
|
|
hx-post="/hosts/{{$host.ID}}/schedules/{{.ID}}/run"
|
|
hx-swap="none"
|
|
hx-disabled-elt="this">Run now</button>
|
|
{{end}}
|
|
<a href="/hosts/{{$host.ID}}/schedules/{{.ID}}/edit" class="btn">Edit</a>
|
|
<form method="post" action="/hosts/{{$host.ID}}/schedules/{{.ID}}/delete" style="display: inline;"
|
|
onsubmit="return confirm('Delete this schedule? Existing snapshots are not affected.');">
|
|
<button type="submit" class="btn btn-danger">Delete</button>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
|
|
</div>
|
|
{{end}}
|