steve
e7eea7afac
Go-side data model rebuilt against migration 0008. The fat-Schedule
shape (paths/excludes/tags/retention/manual/kind/options/hooks) is
gone; that surface lives on source_groups now.
* store/types.go
- Schedule slimmed to {id, host_id, cron, enabled, source_group_ids,
timestamps}. SourceGroupIDs populated by Get/List, accepted on
Create/Update so callers pass desired junction state in one shape.
- SourceGroup added: name (= snapshot tag), includes/excludes,
retention_policy, retry_max + retry_backoff_seconds, cached
conflict_dimension.
- HostRepoMaintenance added: forget/prune/check cadences + enabled.
- PendingRun added: offline-retry queue.
- Host loses RepoInitialisedAt; gains BandwidthUpKBps + BandwidthDownKBps.
- RetentionPolicy moves home from "schedule field" to "source group
field" but the type itself + Summary() method unchanged.
* store/sources.go (new) — CRUD + GetByName + ConflictDimension cache.
Group writes bump host_schedule_version; conflict cache writes don't
(server-internal projection, agent doesn't see it).
* store/maintenance.go (new) — CreateDefault is idempotent (INSERT OR
IGNORE). UpdateRepoMaintenance doesn't bump schedule version because
these run on the server's own ticker, not the agent's local cron.
* store/pending.go (new) — Enqueue / DueRunsForRetry / Bump / Delete.
* store/schedules.go — rewritten for slim shape + junction CRUD.
Update wipes the schedule_source_groups junction wholesale and
re-inserts (simpler than diffing). Adds SchedulesUsingGroup for
retention-conflict detection + UI labels.
* store/hosts.go — drops repo_initialised_at scan, adds bandwidth scan.
New SetHostBandwidth helper.
* HTTP layer — temporarily stubbed during this rewrite (501 returns
with redesign_in_progress error code). Phase 3 fills these in
against the new shape:
- schedules.go REST CRUD
- schedule_push.go agent reconciliation
- ui_schedules.go HTML form CRUD
Run-now-per-host + Init-repo handlers in ui_handlers.go also stubbed
— both go away in the new model (Run-now per source group; auto-init
at host enrolment).
* enrollment.go — replaces "seed manual schedule from typed paths"
with "seed default source group + repo-maintenance row." The default
group gets the typed paths as its includes; operator edits later
via Sources tab.
* ws/handler.go — drops the MarkHostRepoInitialised projection (column
is gone; auto-init makes it derivable from latest init job's status).
Tests:
* store: existing schedule test rewritten for slim shape + junction;
new sources_test.go covers source-group CRUD, name uniqueness,
conflict cache, repo-maintenance defaults + idempotent seed,
pending-runs queue lifecycle.
* http: schedules_test.go and schedule_push_test.go deleted — both
exercised the obsolete fat-schedule API. Phase 3 rewrites them
against the new endpoints.
go test ./... green. cmd/server + cmd/agent build. The UI is broken
end-to-end (schedules / sources / repo tabs all hit 501 stubs); Phase 3
restores REST + on-the-wire reconciliation; Phase 4 rewires the UI
templates against the new model.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
75 lines
2.5 KiB
Go
75 lines
2.5 KiB
Go
package store
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
// CreateDefaultRepoMaintenance inserts the default cadences for a
|
|
// host. Called once at host enrolment alongside CreateHost. Safe to
|
|
// re-call (uses INSERT OR IGNORE so a manual repair doesn't blow up
|
|
// an already-seeded host).
|
|
func (st *Store) CreateDefaultRepoMaintenance(ctx context.Context, hostID string) error {
|
|
_, err := st.db.ExecContext(ctx,
|
|
`INSERT OR IGNORE INTO host_repo_maintenance (host_id) VALUES (?)`,
|
|
hostID)
|
|
if err != nil {
|
|
return fmt.Errorf("store: seed repo maintenance: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetRepoMaintenance returns the cadence row for a host. Returns
|
|
// ErrNotFound if absent — caller should usually treat that as
|
|
// "needs CreateDefaultRepoMaintenance" rather than a hard error.
|
|
func (st *Store) GetRepoMaintenance(ctx context.Context, hostID string) (*HostRepoMaintenance, error) {
|
|
row := st.db.QueryRowContext(ctx,
|
|
`SELECT host_id, forget_cron, forget_enabled,
|
|
prune_cron, prune_enabled,
|
|
check_cron, check_enabled, check_subset_pct
|
|
FROM host_repo_maintenance WHERE host_id = ?`, hostID)
|
|
var (
|
|
m HostRepoMaintenance
|
|
forgetEnabled, pruneEnabled, checkEnabled int
|
|
)
|
|
err := row.Scan(&m.HostID,
|
|
&m.ForgetCron, &forgetEnabled,
|
|
&m.PruneCron, &pruneEnabled,
|
|
&m.CheckCron, &checkEnabled, &m.CheckSubsetPct)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, ErrNotFound
|
|
}
|
|
if err != nil {
|
|
return nil, fmt.Errorf("store: get repo maintenance: %w", err)
|
|
}
|
|
m.ForgetEnabled = forgetEnabled != 0
|
|
m.PruneEnabled = pruneEnabled != 0
|
|
m.CheckEnabled = checkEnabled != 0
|
|
return &m, nil
|
|
}
|
|
|
|
// UpdateRepoMaintenance replaces every editable field. Doesn't bump
|
|
// the schedule version — these run on the server's own ticker, not
|
|
// the agent's local cron, so the agent doesn't need to know.
|
|
func (st *Store) UpdateRepoMaintenance(ctx context.Context, m *HostRepoMaintenance) error {
|
|
if m.HostID == "" {
|
|
return errors.New("store: repo maintenance host_id required")
|
|
}
|
|
_, err := st.db.ExecContext(ctx,
|
|
`UPDATE host_repo_maintenance SET
|
|
forget_cron = ?, forget_enabled = ?,
|
|
prune_cron = ?, prune_enabled = ?,
|
|
check_cron = ?, check_enabled = ?, check_subset_pct = ?
|
|
WHERE host_id = ?`,
|
|
m.ForgetCron, boolToInt(m.ForgetEnabled),
|
|
m.PruneCron, boolToInt(m.PruneEnabled),
|
|
m.CheckCron, boolToInt(m.CheckEnabled), m.CheckSubsetPct,
|
|
m.HostID)
|
|
if err != nil {
|
|
return fmt.Errorf("store: update repo maintenance: %w", err)
|
|
}
|
|
return nil
|
|
}
|