steve
a837b25d73
Adds the admin/diagnostics surface from SPEC §7.2: - doctor [--account]: per-account IMAP + (RW) SMTP connectivity/auth checks via new mail.CheckIMAP/CheckSMTP (connect+auth only, no mail). Exit non-zero on any failure; secrets never printed. - store.UpdateAccount: partial edit, re-encrypts password/secrets only when a non-empty value is supplied (blank keeps existing). RecentAuditFor(account). - config set/get (validates audit_retention_days), audit list [--account][--limit], account edit (flag partial-update) / remove [--yes]. - internal/tui: bubbletea AccountForm with pure, fully-tested Fields (validation + store.Account assembly + edit prefill). init / bare `account add` / `account edit --name X` drop into the TUI; flag forms remain for scripting. Built test-first; full suite green incl -race. Validated live against the mxlogin (password) and Gmail (app-password) accounts. Live validation caught a real bug: doctor authenticated with empty passwords because it iterated ListAccounts (which strips secrets) — fixed to re-fetch via GetAccount, locked in by a regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
57 lines
1.7 KiB
Go
57 lines
1.7 KiB
Go
package cli
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestRunUnknownCommand(t *testing.T) {
|
|
var out, errOut bytes.Buffer
|
|
code := Run([]string{"frobnicate"}, &out, &errOut)
|
|
if code == 0 {
|
|
t.Fatal("unknown command should be non-zero exit")
|
|
}
|
|
if !strings.Contains(errOut.String(), "unknown") {
|
|
t.Fatalf("stderr should mention unknown command: %q", errOut.String())
|
|
}
|
|
}
|
|
|
|
func TestRunVersionIsJSONForAgentButTextHere(t *testing.T) {
|
|
// `account list` with no DB key should fail closed with a usage/config error,
|
|
// proving the key check happens before any DB work.
|
|
var out, errOut bytes.Buffer
|
|
t.Setenv("EMCLI_KEY", "")
|
|
code := Run([]string{"account", "list"}, &out, &errOut)
|
|
if code == 0 {
|
|
t.Fatal("missing EMCLI_KEY must fail")
|
|
}
|
|
if !strings.Contains(out.String()+errOut.String(), "EMCLI_KEY") {
|
|
t.Fatalf("should mention EMCLI_KEY, got out=%q err=%q", out.String(), errOut.String())
|
|
}
|
|
}
|
|
|
|
func TestListUsageErrorIsJSON(t *testing.T) {
|
|
// Agent command with a missing required flag emits a JSON error envelope.
|
|
var out, errOut bytes.Buffer
|
|
t.Setenv("EMCLI_KEY", b64Key())
|
|
t.Setenv("EMCLI_DB", "") // default path is fine; command fails before connecting
|
|
code := Run([]string{"list"}, &out, &errOut) // missing --account
|
|
if code == 0 {
|
|
t.Fatal("missing --account should be non-zero")
|
|
}
|
|
var env map[string]any
|
|
if err := json.Unmarshal(out.Bytes(), &env); err != nil {
|
|
t.Fatalf("agent usage error must be JSON, got %q", out.String())
|
|
}
|
|
if env["error"] != true {
|
|
t.Fatalf("want error envelope: %v", env)
|
|
}
|
|
}
|
|
|
|
func b64Key() string {
|
|
// 32 zero bytes, base64.
|
|
return "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
|
|
}
|