steve/restic-manager
1
0
Fork 0
Code Issues Pull Requests Actions Projects Releases 5 Wiki Activity

Fix agent panic on WebSocket disconnect #38

Merged
steve merged 2 commits from fix-issue-37-ws-disconnect-panic into main 2026-08-22 09:49:37 +01:00
Conversation 0 Commits 2 Files Changed 2
+50 -5
steve commented 2026-08-22 09:45:29 +01:00
Owner
Copy Link
Copy Source

Summary

  • stop closing the successful WebSocket upgrade response body, which coder/websocket deliberately sets to nil
  • rely on Conn.CloseNow to release the upgraded stream
  • add a regression test covering a successful handshake followed by a normal disconnect

Verification

  • go test ./...
  • git diff --check

Fixes #37

## Summary - stop closing the successful WebSocket upgrade response body, which coder/websocket deliberately sets to nil - rely on Conn.CloseNow to release the upgraded stream - add a regression test covering a successful handshake followed by a normal disconnect ## Verification - go test ./... - git diff --check Fixes #37
steve added 1 commit 2026-08-22 09:45:29 +01:00
fix(agent): avoid panic on websocket disconnect
CI / Test (server-http) (pull_request) Successful in 5s
Details
CI / Test (rest) (pull_request) Successful in 7s
Details
CI / Test (store) (pull_request) Successful in 5s
Details
CI / Build (windows/amd64) (pull_request) Successful in 7s
Details
CI / Lint (pull_request) Failing after 10s
Details
CI / Build (linux/arm64) (pull_request) Successful in 8s
Details
CI / Build (linux/amd64) (pull_request) Successful in 24s
Details
e2e / Playwright vs docker-compose (pull_request) Successful in 1m36s
Details
39aff83837
steve added 1 commit 2026-08-22 09:46:52 +01:00
chore(lint): document websocket response ownership
CI / Test (rest) (pull_request) Successful in 38s
Details
CI / Lint (pull_request) Successful in 7s
Details
CI / Test (store) (pull_request) Successful in 39s
Details
CI / Build (windows/amd64) (pull_request) Successful in 22s
Details
CI / Build (linux/amd64) (pull_request) Successful in 8s
Details
CI / Build (linux/arm64) (pull_request) Successful in 7s
Details
CI / Test (server-http) (pull_request) Successful in 1m38s
Details
e2e / Playwright vs docker-compose (pull_request) Successful in 1m22s
Details
dfe082629f
steve merged commit 528bdef433 into main 2026-08-22 09:49:37 +01:00
steve deleted branch fix-issue-37-ws-disconnect-panic 2026-08-22 09:49:37 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
enhancement
New feature or improvement to existing functionality
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/restic-manager#38
Delete Branch "fix-issue-37-ws-disconnect-panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?